Extend admin client with describe and alter configs #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
describeConfigsandalterConfigsAdded e2e tests covering these changes, however at current state of this repo, they do not run on CI (happy to help if you want to set up them to run on CI, however the question is if they are all good for sure with current main)
Fixed docker-compose.yml to current standard.
**The issue I could not manage to sort out is filtering requested configs on broker side. **
I have tried many different approaches, but none of them succeeded.
The issue is open on librdkafka repo (confluentinc/librdkafka#5033) as it looks like it is impossible to get it, unless there is some workaround I could not find, however it still works but can be improved, so I consider it good to go anyway.